Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Remove old icons - #13721

Merged
Hainish merged 2 commits into
EFForg:masterfrom
Bisaloo:rm-icons
Dec 4, 2017
Merged

Hainish merged 2 commits into
EFForg:masterfrom
Bisaloo:rm-icons

Conversation

@Bisaloo

@Bisaloo Bisaloo commented Nov 23, 2017

Copy link
Copy Markdown
Collaborator

Those files have the old version of HTTPS Everywhere icon. It is not used anymore.

@J0WI J0WI added this to the Before the Next Release milestone Nov 26, 2017
@jeremyn

jeremyn commented Dec 1, 2017

Copy link
Copy Markdown
Contributor

The appropriate entries should be removed from https://github.com/EFForg/https-everywhere/blob/568d2c58f7ec1c000a3f243afe0d97ed899b2d50/src/META-INF/manifest.mf or that file should be regenerated. (I'm not sure how to regenerate it.)

The reference to icon.jpg should also be removed from

do_not_ship="*.py *.xml icon.jpg"

@Bisaloo

Bisaloo commented Dec 2, 2017

Copy link
Copy Markdown
Collaborator Author

@jeremyn, I'm not sure how to regenerate manifest.mf either. I thought it was done automatically on release but I can't do it using make.sh.

@Hainish

Hainish commented Dec 4, 2017

Copy link
Copy Markdown
Member

@Bisaloo you don't have to worry about regenerating manifest.mf, this is delivered to us by AMO during the release process.

@Hainish
Hainish merged commit 0bb320d into EFForg:master Dec 4, 2017
@Hainish

Hainish commented Dec 4, 2017

Copy link
Copy Markdown
Member

Thank you

@Bisaloo
Bisaloo deleted the rm-icons branch December 5, 2017 06:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants